-
Notifications
You must be signed in to change notification settings - Fork 1.9k
refactor(schema-compiler): Drop support for disabling native workers … #10196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(schema-compiler): Drop support for disabling native workers … #10196
Conversation
| import os from 'os'; | ||
| import path from 'path'; | ||
| import syntaxCheck from 'syntax-error'; | ||
| import { parse } from '@babel/parser'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good side effect: Cube cloud runtime will not load babel anymore
KSDaemon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM!
…ke TRANSPILATION_WORKER_THREADS new default
3411787 to
c111015
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10196 +/- ##
==========================================
+ Coverage 54.57% 54.66% +0.09%
==========================================
Files 217 217
Lines 17019 17001 -18
Branches 3476 3470 -6
==========================================
+ Hits 9288 9294 +6
+ Misses 7230 7211 -19
+ Partials 501 496 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This flag is enabled by default for a long time and there are not side effect. I am working on speeding up Cube startup and I've figure out that we load babel, which we don't need in the Cube Cloud Runtime, because it uses native transpilers. So, let's remove this env variable and speedup cloud as side effect. Thanks
Supersedes and closes #9643