Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Nov 27, 2025

This flag is enabled by default for a long time and there are not side effect. I am working on speeding up Cube startup and I've figure out that we load babel, which we don't need in the Cube Cloud Runtime, because it uses native transpilers. So, let's remove this env variable and speedup cloud as side effect. Thanks

Supersedes and closes #9643

@ovr ovr requested review from a team as code owners November 27, 2025 16:07
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Nov 27, 2025
import os from 'os';
import path from 'path';
import syntaxCheck from 'syntax-error';
import { parse } from '@babel/parser';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good side effect: Cube cloud runtime will not load babel anymore

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@ovr ovr force-pushed the refactor/drop-support-for-transpilete-without-workers branch from 3411787 to c111015 Compare November 28, 2025 09:41
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.66%. Comparing base (53d79bb) to head (f0508cb).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-backend-shared/src/env.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10196      +/-   ##
==========================================
+ Coverage   54.57%   54.66%   +0.09%     
==========================================
  Files         217      217              
  Lines       17019    17001      -18     
  Branches     3476     3470       -6     
==========================================
+ Hits         9288     9294       +6     
+ Misses       7230     7211      -19     
+ Partials      501      496       -5     
Flag Coverage Δ
cube-backend 54.66% <85.71%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr merged commit c7bf7d7 into master Nov 28, 2025
72 of 74 checks passed
@ovr ovr deleted the refactor/drop-support-for-transpilete-without-workers branch November 28, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants